fix(types): use correct default export#901
Open
plushdohn wants to merge 1 commit intoporsager:masterfrom
Open
Conversation
|
Would like this one merged please 👍 |
Owner
|
Needs some more thumbs up from other typescript users to confirm this doesn't break anything? (i don't use typescript so can't tell) |
porsager
force-pushed
the
master
branch
2 times, most recently
from
4fd011e to
a92f470
Compare
porsager
force-pushed
the
master
branch
2 times, most recently
from
4a0fe34 to
3a43815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #862 by ensuring classes defined under the
postgresnamespace aren't also available as a named export, but only under the defaultpostgres.export.I've tested the change by patching the module in my projects, but I'm not sure if under some specific Typescript scenarios the behaviour could be incorrect.
Trying to import
PostgresErroras a named export:And here's the correct usage using the default export: